Update web3js 4 With Injected provider #4166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yann300
added this to In progress
in 0.37.0 - Feature Freeze 31/10 - Release 07/11
via automation
yann300
force-pushed
the
update_web3js_4
branch
2 times, most recently
from
6134d90
to
cfff5be
Compare
yann300
commented
Oct 31, 2023
| const compiledContracts = await this.call('compilerArtefacts', 'getAllContractDatas') | ||
| const injectedError = txExecution.checkError({ errorMessage: errorObj.error, errorData: errorObj.errorData }, compiledContracts) | ||
| const injectedError = txExecution.checkError({ errorMessage: errorObj }, compiledContracts) |
There was a problem hiding this comment.
Check custom error.
| } | ||
|
|
||
| signMessage (message, account, _passphrase, cb) { | ||
| const messageHash = hashPersonalMessage(Buffer.from(message)) | ||
| try { | ||
| message = isHexString(message) ? message : Web3.utils.utf8ToHex(message) | ||
| this.executionContext.web3().eth.personal.sign(message, account, (error, signedData) => { | ||
| this.executionContext.web3().eth.personal.sign(message, account).then((error, signedData) => { |
There was a problem hiding this comment.
This change can be an async await call, since it is in a try catch statement. That way we eliminate duplicate catch functions. Just a suggestion, it doesn't need to be changed.
0.37.0 - Feature Freeze 31/10 - Release 07/11
automation
moved this from In progress
to Reviewer approved
Oct 31, 2023
ioedeveloper
approved these changes
Oct 31, 2023
yann300
force-pushed
the
update_web3js_4
branch
3 times, most recently
from
1e8737e
to
608a921
Compare
Aniket-Engg
force-pushed
the
update_web3js_4
branch
from
608a921
to
5891160
Compare
Aniket-Engg
force-pushed
the
update_web3js_4
branch
from
5891160
to
c8fa9b0
Compare
0.37.0 - Feature Freeze 31/10 - Release 07/11
automation
moved this from Reviewer approved
to Done
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix sending tx with injected & walletconnect.