Compile details update #4167
Merged
Compile details update #4167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeizang
added this to In progress
in 0.37.0 - Feature Freeze 31/10 - Release 07/11
via automation
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joeizang
force-pushed
the
compile-details-update
branch
from
f86145f
to
6cb5de9
Compare
yann300
reviewed
Oct 27, 2023
| @@ -13,6 +14,10 @@ export interface RemixUiCompileDetailsProps { | |||
| saveAs: any | |||
| } | |||
|
|
|||
| export type ContractPropertyName = 'compilerInput' | 'name' | 'metadata' | 'bytecode' | 'abi' | 'storageLayout' | |||
There was a problem hiding this comment.
this type is already define below, we should have one declaration. I know this add a dependency, but that's probably better than duplicating the types.
yann300
reviewed
Oct 30, 2023
| @@ -1,6 +1,8 @@ | |||
| import { CopyToClipboard } from '@remix-ui/clipboard' | |||
| import { CustomTooltip } from '@remix-ui/helper' | |||
| import { TreeView, TreeViewItem } from '@remix-ui/tree-view' | |||
| // eslint-disable-next-line @nrwl/nx/enforce-module-boundaries | |||
| import { ContractPropertyName } from 'libs/remix-ui/solidity-compiler/src/lib/types' | |||
There was a problem hiding this comment.
please check but I think this isn't the right to write this import. You hae to use the module name (solidity-compiler)
There was a problem hiding this comment.
You are right. Its done.
yann300
approved these changes
Oct 30, 2023
0.37.0 - Feature Freeze 31/10 - Release 07/11
automation
moved this from In progress
to Reviewer approved
Oct 30, 2023
joeizang
force-pushed
the
compile-details-update
branch
from
1e96107
to
695d882
Compare
0.37.0 - Feature Freeze 31/10 - Release 07/11
automation
moved this from Reviewer approved
to Done
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.