Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation details cleanup #4178

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Compilation details cleanup #4178

merged 4 commits into from
Nov 1, 2023

Conversation

joeizang
Copy link
Collaborator

Clean up wrong entries and remove wrongly placed files.

@joeizang joeizang added the ready-to-review PR ready to review label Oct 31, 2023
@joeizang joeizang self-assigned this Oct 31, 2023
@joeizang joeizang added this to In progress in 0.37.0 - Feature Freeze 31/10 - Release 07/11 via automation Oct 31, 2023
@netlify
Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 4642905
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/654194059bdfcb000808f5b0
😎 Deploy Preview https://deploy-preview-4178--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -114,7 +114,8 @@ export function isNative(name) {
'injected',
'doc-gen',
'doc-viewer',
'circuit-compiler'
'circuit-compiler',
'compliationDetails'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a typo in this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh!!! I will fix it now.

0.37.0 - Feature Freeze 31/10 - Release 07/11 automation moved this from In progress to Reviewer approved Oct 31, 2023
@joeizang joeizang merged commit ca73f36 into master Nov 1, 2023
32 checks passed
0.37.0 - Feature Freeze 31/10 - Release 07/11 automation moved this from Reviewer approved to Done Nov 1, 2023
@joeizang joeizang deleted the compilation-details-cleanup branch November 1, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants