create lang selector component #4179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeizang
added this to In progress
in 0.37.0 - Feature Freeze 31/10 - Release 07/11
via automation
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joeizang
force-pushed
the
lang-dropdown-hometab
branch
from
54799dc
to
8ed2c75
Compare
joeizang
force-pushed
the
lang-dropdown-hometab
branch
from
dd61d51
to
629388a
Compare
ryestew
requested changes
Nov 1, 2023
There was a problem hiding this comment.
The page has to be very very wide to see the language selector. At least 1805px - for it to be totally in view. It needs to be visible when the page is less wide.
Could the language switching be tracked in matomo - both on the switcher and also in the Settings panel and also via URL. Some of these requests may be out of scope for this PR.
0.37.0 - Feature Freeze 31/10 - Release 07/11
automation
moved this from In progress
to Review in progress
Nov 1, 2023
Aniket-Engg
force-pushed
the
lang-dropdown-hometab
branch
2 times, most recently
from
0069498
to
ebc392d
Compare
|
The selector should listen for changes in the Settings panel or in the language selected via a URL. These are edge cases - so either these should be addresses in this PR or these can be addressed in the next release. |
joeizang
force-pushed
the
lang-dropdown-hometab
branch
from
ebc392d
to
2f26e30
Compare
ryestew
approved these changes
Nov 1, 2023
0.37.0 - Feature Freeze 31/10 - Release 07/11
automation
moved this from Review in progress
to Reviewer approved
Nov 1, 2023
0.37.0 - Feature Freeze 31/10 - Release 07/11
automation
moved this from Reviewer approved
to Done
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds dropdown selector where IDE text can be switched based on language code selected.