consider remappings while compilation #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yann300
reviewed
Nov 10, 2023
| const sources = { [target]: { content } } | ||
| this.event.emit('removeAnnotations') | ||
| this.event.emit('startingCompilation') | ||
| if(!this.useFileConfiguration && await this.api.fileExists('remappings.txt')) { |
There was a problem hiding this comment.
even if the fileConfiguration is used, maybe still relevant to useremappings.txt. what's the behavior in foundry?
There was a problem hiding this comment.
I mean in foundry who has the priority, remapping.txt or the compileConfig, or is this a merge of both?
There was a problem hiding this comment.
Foundry picks the remappings from remappings.txt and foundry.toml both. CompilerConfig is specific to Remix
yann300
approved these changes
Nov 10, 2023
v0.38.0 - Feature Freeze 29/11
automation
moved this from In progress
to Reviewer approved
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mappings will be fetched from remapping.txt file