added e2e to verify remappings #4267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Aniket-Engg
force-pushed
the
remapE2e
branch
from
1319de8
to
0a68d0d
Compare
yann300
reviewed
Nov 23, 2023
| .addFile('contracts/lib/storage/src/Storage.sol', { content: retrieverContract }) | ||
| .addFile('remappings.txt', { content: 'storage=contracts/lib/storage/src' }) | ||
| .addFile('contracts/Retreiver.sol', { content: storageContract }) | ||
| .verifyContracts(['Retreiver', 'Storage']) |
There was a problem hiding this comment.
typo, the test should actually fails.
There was a problem hiding this comment.
no, remappings are defined, so it will pass.
There was a problem hiding this comment.
I mean you are checking Retreiver but the contract is named Retriever
Aniket-Engg
force-pushed
the
remapE2e
branch
3 times, most recently
from
f5faabd
to
e23683d
Compare
yann300
approved these changes
Nov 23, 2023
v0.38.0 - Feature Freeze 29/11
automation
moved this from In progress
to Reviewer approved
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4235