Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

left highlight for active plugin icon #4292

Merged
merged 3 commits into from
Dec 5, 2023
Merged

left highlight for active plugin icon #4292

merged 3 commits into from
Dec 5, 2023

Conversation

LianaHus
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 007fd18
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/656f5c5bb615060008652362
😎 Deploy Preview https://deploy-preview-4292--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vermouth22
Copy link
Collaborator

Looks like some Chrome timeout issue? .... but otherwise looks cool.

Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine but I see you have reduced vertical gap between icons. And At some place icon highlight touches another icon

@yann300 yann300 added this to In progress in v0.38.1 via automation Dec 4, 2023
@LianaHus LianaHus moved this from In progress to Review in progress in v0.38.1 Dec 5, 2023
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

v0.38.1 automation moved this from Review in progress to Reviewer approved Dec 5, 2023
@yann300 yann300 merged commit 1e770c0 into master Dec 5, 2023
32 checks passed
v0.38.1 automation moved this from Reviewer approved to Done Dec 5, 2023
@yann300 yann300 deleted the selvi branch December 5, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v0.38.1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants