fix parser: remappings #4309
Merged
fix parser: remappings #4309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Aniket-Engg
reviewed
Dec 6, 2023
| if (await this.plugin.call('fileManager', 'exists','remappings.txt')) { | ||
| const remappings = await this.plugin.call('fileManager', 'readFile','remappings.txt') | ||
| this.compiler.set('remappings', remappings.split('\n').filter(Boolean)) | ||
| } |
There was a problem hiding this comment.
Please add an else section to reset the state which helps when remapping file is deleted.
Aniket-Engg
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows our solidity parser to use the
remappings.txtfile.To test it, create a workspace if type v4 periphery, update submodules, it will show an error in the editor at the top.