Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unknown icon form plugin without a logo #4324

Merged
merged 3 commits into from
Dec 19, 2023
Merged

unknown icon form plugin without a logo #4324

merged 3 commits into from
Dec 19, 2023

Conversation

LianaHus
Copy link
Collaborator

@LianaHus LianaHus commented Dec 11, 2023

fixing #3466
fixing #3772

Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 2e283ee
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/6581651faf452f00085ea36d
😎 Deploy Preview https://deploy-preview-4324--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if question mark icon is the right choice for this. May be use plug-in icon instead

@Aniket-Engg Aniket-Engg added this to In progress in v0.39.0 via automation Dec 11, 2023
@LianaHus
Copy link
Collaborator Author

I am not sure if question mark icon is the right choice for this. May be use plug-in icon instead

ok, Can you check again? @Aniket-Engg

Copy link
Collaborator

@joeizang joeizang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The broken icon is fixed and shows correctly. But the UMA icon is now broken. See image below
image

@Aniket-Engg
Copy link
Collaborator

Screenshot 2023-12-19 at 2 50 02 PM

@joeizang It looks fine to me

v0.39.0 automation moved this from In progress to Reviewer approved Dec 19, 2023
@Aniket-Engg Aniket-Engg merged commit 911e777 into master Dec 19, 2023
32 checks passed
v0.39.0 automation moved this from Reviewer approved to Done Dec 19, 2023
@Aniket-Engg Aniket-Engg deleted the pluginMan branch December 19, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants