Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned panel updates #4829

Merged
merged 8 commits into from
Jun 4, 2024
Merged

Pinned panel updates #4829

merged 8 commits into from
Jun 4, 2024

Conversation

ioedeveloper
Copy link
Member

Closes #4824

Copy link

netlify bot commented May 31, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 4c62d5a
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/665e237492c45a0008696bc2
😎 Deploy Preview https://deploy-preview-4829--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ioedeveloper ioedeveloper force-pushed the pinned-panel-updates branch 2 times, most recently from b072cf7 to 47b365d Compare June 3, 2024 11:56
@ioedeveloper ioedeveloper marked this pull request as ready for review June 3, 2024 11:57
@ioedeveloper ioedeveloper added the ready-to-review PR ready to review label Jun 3, 2024
@ioedeveloper ioedeveloper added this to In progress in v0.50.0 - Feature Freeze 03/06 via automation Jun 3, 2024
@ryestew
Copy link
Collaborator

ryestew commented Jun 4, 2024

The cursor should switch to a finger when over the icon to move it to the right or left side. In a future version there should be a mouseover state of the icon - maybe in bold. But the tooltip makes it clear that there will be an action happening. So I will just leave this as a comment for this PR and not a required change.

v0.50.0 - Feature Freeze 03/06 automation moved this from In progress to Reviewer approved Jun 4, 2024
Copy link
Collaborator

@ryestew ryestew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has my approval - but see the note and someone else should approve this as well.

@Aniket-Engg Aniket-Engg merged commit bde6219 into master Jun 4, 2024
32 checks passed
v0.50.0 - Feature Freeze 03/06 automation moved this from Reviewer approved to Done Jun 4, 2024
@Aniket-Engg Aniket-Engg deleted the pinned-panel-updates branch June 4, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Development

Successfully merging this pull request may close these issues.

side-panel improvements
4 participants