Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation Details Patch #4886

Merged
merged 6 commits into from
Jun 17, 2024
Merged

Compilation Details Patch #4886

merged 6 commits into from
Jun 17, 2024

Conversation

joeizang
Copy link
Collaborator

fixes #4187

@joeizang joeizang added the ready-to-review PR ready to review label Jun 13, 2024
@joeizang joeizang self-assigned this Jun 13, 2024
Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit c4f9052
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/667016e1e2e4930008fcf740
😎 Deploy Preview https://deploy-preview-4886--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have check all the items from issue #4187 but I think not everything is implemented in this like Remove the question mark and add tooltips instead, Add contract name to the file title etc

@joeizang
Copy link
Collaborator Author

You have check all the items from issue #4187 but I think not everything is implemented in this like Remove the question mark and add tooltips instead, Add contract name to the file title etc

Ok Lemme check again.

@joeizang joeizang force-pushed the compile-details-patch branch 2 times, most recently from 79437d7 to faedb14 Compare June 14, 2024 23:41
@joeizang
Copy link
Collaborator Author

You have check all the items from issue #4187 but I think not everything is implemented in this like Remove the question mark and add tooltips instead, Add contract name to the file title etc

I was unable to achieve placing the contract name as the name of the tab. TabProxy will need some refactoring, I think. The situation here is when showing the compile details, a file isn't being opened, which tabproxy can handle easily. I would say this can be fixed in another pr for another release. Everything else seems fine.

@Aniket-Engg
Copy link
Collaborator

You have check all the items from issue #4187 but I think not everything is implemented in this like Remove the question mark and add tooltips instead, Add contract name to the file title etc

I was unable to achieve placing the contract name as the name of the tab. TabProxy will need some refactoring, I think. The situation here is when showing the compile details, a file isn't being opened, which tabproxy can handle easily. I would say this can be fixed in another pr for another release. Everything else seems fine.

please create an issue to track it

@Aniket-Engg Aniket-Engg merged commit 0e54bdb into master Jun 17, 2024
32 checks passed
@Aniket-Engg Aniket-Engg deleted the compile-details-patch branch June 17, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compilation details improvement story
2 participants