-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation Details Patch #4886
Conversation
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
f2707ca
to
f23f9a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have check all the items from issue #4187 but I think not everything is implemented in this like Remove the question mark and add tooltips instead
, Add contract name to the file title
etc
Ok Lemme check again. |
79437d7
to
faedb14
Compare
I was unable to achieve placing the contract name as the name of the tab. TabProxy will need some refactoring, I think. The situation here is when showing the compile details, a file isn't being opened, which tabproxy can handle easily. I would say this can be fixed in another pr for another release. Everything else seems fine. |
please create an issue to track it |
a4afcbc
to
c4f9052
Compare
fixes #4187