Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show log in github from FE #4979

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Show log in github from FE #4979

wants to merge 6 commits into from
+135 −59

Conversation

yann300
Copy link
Contributor

@yann300 yann300 commented Jul 10, 2024

this put the "Log in Github" in the File Explorer.

@netlify Netlify
Copy link

netlify bot commented Jul 10, 2024 •
edited
Loading

✅ Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 5363fff
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/66901269aa75660008db9d3f
😎 Deploy Preview https://deploy-preview-4979--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yann300 yann300 added the ready-to-review PR ready to review label Jul 10, 2024
@LianaHus
Copy link
Collaborator

I would suggest redesigning a bit:
Screenshot from 2024-07-11 10-38-48
Screenshot from 2024-07-11 10-38-25

@LianaHus
Copy link
Collaborator

LianaHus commented Jul 11, 2024 •
edited
Loading

  • IMO "Log in to GitHub" is enough we do not need "Click to" in the tooltip
  • I would suggest to use "Sign in" as a label and in tooltip instead of "Log in"

Screenshot from 2024-07-11 10-43-18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bunsenstraat bunsenstraat Awaiting requested review from bunsenstraat

@LianaHus LianaHus Awaiting requested review from LianaHus

@Aniket-Engg Aniket-Engg Awaiting requested review from Aniket-Engg

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ready-to-review PR ready to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yann300 @LianaHus