This repository has been archived by the owner on Mar 3, 2021. It is now read-only.
Remix Tests Typescript implementation #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remix-tests/src/compiler.ts
Outdated
| } | ||
|
|
||
| function writeTestAccountsContract (accounts: string[]) { | ||
| var testAccountContract = require('../sol/tests_accounts.sol.js') |
There was a problem hiding this comment.
I would recommand using ES6 lazy imports instead of node require :
async function writeTestAccountsContract (accounts: string[]) {
const testAccountContract = await import('../sol/tests_accounts.sol.js')
...
}There was a problem hiding this comment.
This will have to wait till a Promisified version of this library starts being developed.
|
remix-lib failing test is not related |
ethereum/populus is no longer maintained. Use ours.
|
@iurimatias is this ok to merge regarding the workshops next week? |
|
did the rebase worked ok? cause several commits actually belong to master. |
0mkara
changed the title
|
Yes it seems it worked. I can see |
|
i just don't get why this commit cc4dcb5 |
yann300
approved these changes
Mar 25, 2019
I rebased it after your fix last night. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remix Tests Typescript implementation