This repository has been archived by the owner on Mar 3, 2021. It is now read-only.
remix-solidity: add compiler.setEvmVersion() #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a way to pass the `evmVersion` parameter to `solc` by: 1. Simplify the `Compiler.compileJSON()` interface from `compileJSON(source, optimize)` to `compileJSON(source)` Whether optimization is enabled is then always determined by the `Compiler.optimize` object field which simplifies data flow. 2. Add a `Compiler.evmVersion` field and a setter and make `compileJSON()` honor that. Specifying `evmVersion` is useful when targetting an older private chain with the latest `solc` or when using an EVM-compatible chain that's slightly behind Ethereum main-net in terms of features. The unused `userAgent` variable in `onInternalCompilerLoaded` was only removed to fix `npm run test` for `remix-solidity`'.
scottt
added a commit
to thundercore/remix-ide
that referenced
this pull request
May 20, 2019
Specifying a specific EVM version for `solc` to target is useful when targetting older private chains deployments with the latest compiler. This work in progress patch adds an "EVM Version" drop down menu in the compiler tab. This patch depends on ethereum/remix#1193 in `remix-solidity` to pass down the `evmVersion` option.
yann300
approved these changes
Jun 13, 2019
yann300
pushed a commit
to thundercore/remix-ide
that referenced
this pull request
Jun 13, 2019
Specifying a specific EVM version for `solc` to target is useful when targetting older private chains deployments with the latest compiler. This work in progress patch adds an "EVM Version" drop down menu in the compiler tab. This patch depends on ethereum/remix#1193 in `remix-solidity` to pass down the `evmVersion` option.
yann300
pushed a commit
to thundercore/remix-ide
that referenced
this pull request
Jun 17, 2019
Specifying a specific EVM version for `solc` to target is useful when targetting older private chains deployments with the latest compiler. This work in progress patch adds an "EVM Version" drop down menu in the compiler tab. This patch depends on ethereum/remix#1193 in `remix-solidity` to pass down the `evmVersion` option.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to pass the
evmVersionparameterto
solcby:Compiler.compileJSON()interface fromcompileJSON(source, optimize)tocompileJSON(source)Whether optimization is enabled is then always determined by
the
Compiler.optimizeobject field which simplifies data flow.Compiler.evmVersionfield and a setter andmake
compileJSON()honor that.Specifying
evmVersionis useful when targetting an olderprivate chain with the latest
solcor when usingan EVM-compatible chain that's slightly behind Ethereum
main-net in terms of features.
The unused
userAgentvariable inonInternalCompilerLoadedwasonly removed to fix
npm run testforremix-solidity'.