This repository has been archived by the owner on Mar 3, 2021. It is now read-only.
Small spelling typos #1213
Merged
Small spelling typos #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yes please feel free to create a PR, thanks ;) |
yann300
approved these changes
Jun 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking over
remix-libto use in a library that can feed both into an LSP server and client-side IDEs and came across these typos.I offer them if you are interested.
Side note: one thing I don't see in
remix-lib/src/sourceMappingDecoder.jsis the inverse ofconvertFromCharPosition(), that is something that starts out with a line and column number and converts that into an offset. (VSCode for example starts off with positions in this format).Since this is trivial to write, I'll coding that in. If there's interest in adding this to remix-lib, give out a holler.