This repository has been archived by the owner on Mar 3, 2021. It is now read-only.
Enable yul optimizations if optimizations are enabled and in Yul mode. #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
reviewed
Jun 20, 2019
| @@ -24,5 +24,9 @@ module.exports = (sources, opts) => { | |||
| if (opts.language) { | |||
| o.language = opts.language | |||
| } | |||
| if (opts.language == 'Yul' && o.settings.optimizer.enabled) | |||
| { | |||
| o.optimizer.details['yul'] = true | |||
There was a problem hiding this comment.
isn't it o.settings.optimizer
chriseth
force-pushed
the
enableYulOptimizer
branch
from
aa533e9
to
11c185a
Compare
yann300
reviewed
Jun 21, 2019
| @@ -24,5 +24,9 @@ module.exports = (sources, opts) => { | |||
| if (opts.language) { | |||
| o.language = opts.language | |||
| } | |||
| if (opts.language == 'Yul' && o.settings.optimizer.enabled) | |||
| { | |||
| o.settings.optimizer.details['yul'] = true | |||
There was a problem hiding this comment.
i think the property details should be specified (as empty js object) in o.
yann300
approved these changes
Jun 24, 2019
This was referenced Dec 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.