This repository has been archived by the owner on Mar 3, 2021. It is now read-only.
Pass executionContext as args to to try function
#1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aniket-Engg
approved these changes
Jan 15, 2020
| @@ -214,27 +214,27 @@ class TxRunner { | |||
| } | |||
| } | |||
|
|
|||
| async function tryTillReceiptAvailable (txhash, done) { | |||
| async function tryTillReceiptAvailable (txhash, executionContext) { | |||
| return new Promise((resolve, reject) => { | |||
There was a problem hiding this comment.
Would you like to remove this Promise class as async function will return promise anyway.
There was a problem hiding this comment.
not sure that is really possible in this context: the body of the function contain also an async function...
There was a problem hiding this comment.
hmmm, may be we can try and know better later
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.