Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write up process to cut a new release #28

Merged
merged 2 commits into from Nov 16, 2018

Conversation

kclowes
Copy link
Contributor

@kclowes kclowes commented Nov 16, 2018

Let me know if I got something wrong or if I am missing anything!

Copy link
Contributor

@carver carver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's worth converting the numbers into checkboxes (- [ ]) to make it easy to literally check it off when running through the process.

All of these are just suggestions, so take or leave as you please, & merge at will.

1. run `$ make docs` to view the release notes locally. Make sure everything looks like it should.
1. Once the docs look good, commit the changes.
1. Most repos have a section in the README that describes how to use the `make release` script. It looks something like [this](https://github.com/ethereum/web3.py#release-setup). Follow those instructions.
- If something goes wrong in the middle, you'll need to:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a bullet before this with a link to https://semver.org/ and an abbreviated cheat sheat:

  • backwards incompatible: bump major
  • new features: bump minor
  • bugfix/misc only: bump patch

- If something goes wrong in the middle, you'll need to:
- Figure out what went wrong and fix that problem
- Open up the Makefile, and run all commands after the one that failed manually
1. Test it!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a line or two suggesting:

  • create & activate a new virtualenv
  • pip install -U <released_project>
  • open shell and confirm module import works, maybe check a simple feature and/or new features

- Figure out what went wrong and fix that problem
- Open up the Makefile, and run all commands after the one that failed manually
1. Test it!
1. Announce to the Gitter channel. Typically this announcement includes a link to the release docs. :tada:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implicit in this is making sure that the RTD build succeeded. That should happen naturally when getting the deep link to this version's release notes. But maybe worth one more bullet before this to be explicit.

@carver carver merged commit e7d0f27 into ethereum:master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants