Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass prerelease option to nightly builds #123

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

r0qs
Copy link
Member

@r0qs r0qs commented Sep 30, 2022

Updates the CI job to use emscripten_build script with prerelease parameter introduced by ethereum/solidity#13581.

Depends on ethereum/solidity#13581.

@cameel
Copy link
Member

cameel commented Oct 5, 2022

@r0qs Do you need permissions access to solc-bin? We have same problem as last time, i.e. the PR checks won't pass because this is an external PR.

I actually haven't considered that this will affect all contributions. In that case we might want to fix that after all. See ethereum/solidity#13614.

For now I'll just force-merge this one (once the dependency in the main repo is merged).

Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but not approving yet since I have not yet reviewed the dependency in the main repo.

@r0qs
Copy link
Member Author

r0qs commented Oct 6, 2022

@r0qs Do you need permissions access to solc-bin? We have same problem as last time, i.e. the PR checks won't pass because this is an external PR.

No, I have permission. Sorry, it was my mistake, I set two git remote trackers in my fork and pushed the branch to the wrong one, haha
I just realized that I did the same for the other PR in the solidity repo. Should I recreate the PR?

I actually haven't considered that this will affect all contributions. In that case we might want to fix that after all. See ethereum/solidity#13614.

Ah, indeed.

@cameel
Copy link
Member

cameel commented Oct 6, 2022

Should I recreate the PR?

Like I said, I can just force merge it so no need.

@cameel
Copy link
Member

cameel commented Nov 22, 2022

@r0qs This needs to be updated to match ethereum/solidity#13581 (and probably also rebased).

@cameel cameel merged commit f02ca19 into ethereum:gh-pages Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has dependencies The PR depends on other PRs that must be merged first
Projects
None yet
2 participants