Implement support for the new memory allocation API #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
commented
Dec 9, 2019
axic
commented
Dec 9, 2019
leonardoalt
reviewed
Dec 9, 2019
leonardoalt
reviewed
Dec 9, 2019
chriseth
reviewed
Dec 10, 2019
ekpyron
reviewed
Dec 10, 2019
wrapper.js
Outdated
| // The duty is on solc-js to free these pointers. We accomplish that by calling `reset` at the end. | ||
| var buffer; | ||
| if (isVersion6) { | ||
| buffer = alloc(length + 1); |
There was a problem hiding this comment.
To complement my comment on the solidity PR: We can just use alloc(length) here, while still passing length + 1 to stringToUTF8 below and it's guaranteed to be valid, while then the std::string on the solidity side won't contain an additional zero.
leonardoalt
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.