Treat util::Error as unexpected outside of codegen

- In analysis we use an error reporter and never just throw util::Error. We do it in one case in the codegen (CodeGenerationError) but outside of that case this should not be treated as a proper way to report an error.
- Now such errors will be treated as unexpected. They're bugs that should be fixed.

libsolidity/interface/CompilerStack.cpp

@@ -732,8 +732,10 @@ bool CompilerStack::compile(State _stopAfter)
 					}
 					catch (Error const& _error)
 					{
-						if (_error.type() != Error::Type::CodeGenerationError)
-							throw;
+						// Since codegen has no access to the error reporter, the only way for it to
+						// report an error is to throw. In most cases it uses dedicated exceptions,
+						// but CodeGenerationError is one case where someone decided to just throw Error.
+						solAssert(_error.type() == Error::Type::CodeGenerationError);
 						m_errorReporter.error(_error.errorId(), _error.type(), SourceLocation(), _error.what());
 						return false;
 					}

libsolidity/interface/StandardCompiler.cpp

@@ -1360,17 +1360,6 @@ Json StandardCompiler::compileSolidity(StandardCompiler::InputsAndSettings _inpu
 				));
 		}
 	}
-	/// This is only thrown in a very few locations.
-	catch (Error const& _error)
-	{
-		errors.emplace_back(formatErrorWithException(
-			compilerStack,
-			_error,
-			_error.type(),
-			"general",
-			"Uncaught error: "
-		));
-	}
 	catch (CompilerError const& _exception)
 	{
 		errors.emplace_back(formatErrorWithException(

solc/CommandLineInterface.cpp

@@ -915,12 +915,6 @@ void CommandLineInterface::compile()
 		);
 		solThrow(CommandLineExecutionError, "");
 	}
-	catch (Error const& _error)
-	{
-		m_hasOutput = true;
-		formatter.printErrorInformation(_error);
-		solThrow(CommandLineExecutionError, "");
-	}
 }
 
 void CommandLineInterface::handleCombinedJSON()

test/tools/fuzzer_common.cpp

@@ -128,9 +128,6 @@ void FuzzerUtil::testCompiler(
 	{
 		compiler.compile();
 	}
-	catch (Error const&)
-	{
-	}
 	catch (UnimplementedFeatureError const&)
 	{
 	}