Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifying blobhash causes failure to obtain gasLimit #14924

Closed
iteyelmp opened this issue Mar 8, 2024 · 2 comments
Closed

Verifying blobhash causes failure to obtain gasLimit #14924

iteyelmp opened this issue Mar 8, 2024 · 2 comments
Labels

Comments

@iteyelmp
Copy link

iteyelmp commented Mar 8, 2024

Use the newly supported blobhash opcode to obtain the hash, and determine whether the blob is actually uploaded based on the result. But this will cause estimateGas to error because the blob doesn't exist yet.

 bytes32 dataHash = blobhash(blobIdx);
 require(dataHash != 0, "failed to get blob hash");
@cameel
Copy link
Member

cameel commented Mar 8, 2024

Can you provide more details? Is this an error from a framework? Geth?
Are you using a release binary?

We're actually seeing a similar error from some Hardhat projects after switching to cancun by default (#4851) but that's not merged yet. It would be useful to know if you're seeing this on 0.8.24 with cancun selected or if you're using a build from develop with yet unreleased features.

@cameel
Copy link
Member

cameel commented Mar 12, 2024

I'm closing this due to not enough information to diagnose and also because we solved the related problem I mentioned above, and it's very likely that this solves it issue too. The solution was that in our external tests we were configuring Hardhat to use cancun as the EVM version for the compiler but not for the hardhat network. That has to be set separately and currently still defaults to shanghai (NomicFoundation/hardhat#4851).

If this does not solve the problem for you and you can provide more information, feel free to repoen, but first please make sure it's actually a problem in the compiler and not in the framework you're using. If the latter is more likely, please report there instead.

@cameel cameel closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants