-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Cancun by default #4851
Comments
Are you seeing any CI failures with EVM version set to We're not sure if it's just some bit needed for full Cancun support still missing in Hardhat or maybe one of the still unreleased changes in solc that triggers this (the IR codegen starting to use The change also results in massive failures in other external projects we have hooked into CI via Hardhat, like OpenZeppelin. @matheusaaguiar will soon open issues with more details and repros, but you can see the breakage in the failing jobs of ethereum/solidity#14907 (all the |
For the record, this is about setting Cancun as the default hardfork of the Hardhat network. We are not going to use it as the default solc target for a while (we are not even using Shanghai as the default solc target yet). But of course, things should work when Cancun is used as solc's target, so we are going to look into that. Thanks for letting us know! |
An update on the problems on our side. Turns out it actually is related to the default hardfork setting. We only now realized that this setting is completely independent of the EVM version for the compiler and does not default to it. Perhaps it would be a good idea to make it so. In any case, setting it explicitly will probably solve our problem with the external projects we test. |
We had to be conservative after Shanghai, because people could accidentally deploy contracts with |
Hey @fvictorio you might also consider changing this hardcoded setting: https://github.com/NomicFoundation/hardhat/blob/main/packages/hardhat-core/test/internal/hardhat-network/stack-traces/execution.ts#L34 to |
Set cancun as the default config for the hardfork used in Hardhat network. Resolves #4851
We'll do this after Cancun is enabled in mainnet.
To-do:
test/.../default-config.ts
testsrc/.../default-config.ts
forking-different-hardforks.ts
The text was updated successfully, but these errors were encountered: