Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider defaulting to IPFS for metadata hash #5064

Closed
chriseth opened this issue Sep 22, 2018 · 12 comments
Closed

Consider defaulting to IPFS for metadata hash #5064

chriseth opened this issue Sep 22, 2018 · 12 comments

Comments

@chriseth
Copy link
Contributor

Now that cloudflare added an ipfs proxy, we might be much better off defaulting to ipfs.

Any opinions?

@axic
Copy link
Member

axic commented Sep 25, 2018

Do you have a suggestion for metadata configuration options in standard json?

@chriseth
Copy link
Contributor Author

I thought about just switching, but the config option might be named metadataCAS: ipfs (content-addressed-storage)

@chriseth
Copy link
Contributor Author

Added a test file: QmdB5JktqW6LPioJXACMxPqLeB36LtZ4ZN8oE31EkiuAHt

@chriseth
Copy link
Contributor Author

chriseth commented Jul 2, 2019

After some failures, we started another ipfs node on the same network, it automatically connected to the first node and got the file. It still was not on the gateway but when I checked 30 minutes later, it appeared on the gateway. So now I think the next test is to wait for some days and re-check if it is still on the gateway.

@chriseth
Copy link
Contributor Author

chriseth commented Jul 2, 2019

Added another file which we also retrieved via the cloudflare gateway (to see whether its cache might have longer timeouts): QmXqNvVwR4hhNmwotFkHAosXnsxV8M7AdzxePvg5fXvYX8

@chriseth
Copy link
Contributor Author

chriseth commented Jul 8, 2019

The file that was also previously retrieved via cloudflare was available immediately (both on cloudflare and on the "official" gateway). The other file seems to be gone.

@chriseth
Copy link
Contributor Author

File is still present.

@leonardoalt
Copy link
Member

I guess we now have positive data towards IPFS?

@chriseth
Copy link
Contributor Author

Looks like it...

@chriseth
Copy link
Contributor Author

chriseth commented Aug 1, 2019

Still present.

@chriseth
Copy link
Contributor Author

chriseth commented Aug 1, 2019

Will do the change in 0.6.0.

@chriseth chriseth closed this as completed Aug 1, 2019
@chriseth
Copy link
Contributor Author

chriseth commented Sep 9, 2019

Still present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants