Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not warn about functions with empty body. #5295

Closed
chriseth opened this issue Oct 24, 2018 · 1 comment
Closed

Do not warn about functions with empty body. #5295

chriseth opened this issue Oct 24, 2018 · 1 comment
Labels
language design :rage4: Any changes to the language, e.g. new features
Projects
Backlog (non-breaking) 0.5.2

Comments

@chriseth
Copy link
Contributor

chriseth commented Oct 24, 2018 •
edited
Loading

Unused variable warning and state mutability warning should be suppressed for functions with empty body similar to how it is suppressed for functions without implementation.
@chriseth chriseth added the language design :rage4: Any changes to the language, e.g. new features label Oct 24, 2018
@chriseth chriseth added this to Inbox in Backlog (non-breaking) via automation Oct 24, 2018
@chriseth chriseth added this to Inbox in 0.5.2 via automation Nov 29, 2018
@chriseth chriseth mentioned this issue Nov 29, 2018
Closed
@leonardoalt leonardoalt self-assigned this Dec 5, 2018
@chriseth chriseth moved this from Inbox to Ready to be worked on in 0.5.2 Dec 6, 2018
@chriseth chriseth moved this from Ready to be worked on to In progress in 0.5.2 Dec 6, 2018
@leonardoalt leonardoalt removed their assignment Dec 6, 2018
@anurag-git
Copy link
Contributor

@chriseth , I get about state mutability but if function is empty how unused variable warning will come.

@leonardoalt leonardoalt mentioned this issue Dec 12, 2018
Merged
@leonardoalt leonardoalt moved this from In progress to Needs review in 0.5.2 Dec 12, 2018
Backlog (non-breaking) automation moved this from Inbox to Done Dec 12, 2018
0.5.2 automation moved this from Needs review to Done Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language design :rage4: Any changes to the language, e.g. new features
Projects
No open projects
0.5.2
  
Done
Backlog (non-breaking)
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@leonardoalt @chriseth @anurag-git