Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supress unused var and state mut warnings for functions with empty body #5630

Merged
merged 3 commits into from
Dec 12, 2018
Merged

Supress unused var and state mut warnings for functions with empty body #5630

merged 3 commits into from
Dec 12, 2018

Conversation

leonardoalt
Copy link
Member

Fixes #5295

ekpyron
ekpyron previously approved these changes Dec 12, 2018
View reviewed changes
Copy link
Member

@ekpyron ekpyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me!

libsolidity/analysis/StaticAnalyzer.cpp Outdated Show resolved Hide resolved
chriseth
chriseth reviewed Dec 12, 2018
View reviewed changes
Changelog.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 12, 2018 •
edited
Loading

Codecov Report

Merging #5630 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5630      +/-   ##
===========================================
+ Coverage    88.24%   88.25%   +<.01%     
===========================================
  Files          339      339              
  Lines        32465    32467       +2     
  Branches      3884     3883       -1     
===========================================
+ Hits         28649    28653       +4     
+ Misses        2500     2497       -3     
- Partials      1316     1317       +1
Flag Coverage Δ
#all 88.25% <100%> (ø) ⬆️
#syntax 28.56% <100%> (ø) ⬆️

chriseth
chriseth requested changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@chriseth chriseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check should be moved to endVisit.

@leonardoalt
Copy link
Member Author

Updated

@chriseth chriseth merged commit 8723728 into develop Dec 12, 2018
@ekpyron ekpyron deleted the warn_functions_empty_body branch December 12, 2018 19:48
@nventuro nventuro mentioned this pull request Jan 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriseth chriseth chriseth approved these changes

@ekpyron ekpyron ekpyron left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leonardoalt @ekpyron @chriseth