Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow deleting mappings either directly or via array.pop #8535

Closed
7 tasks done
chriseth opened this issue Mar 25, 2020 · 0 comments
Closed
7 tasks done

Disallow deleting mappings either directly or via array.pop #8535

chriseth opened this issue Mar 25, 2020 · 0 comments
Assignees
@Marenz
Labels
breaking change ⚠️ language design :rage4: Any changes to the language, e.g. new features
Projects
Solidity

Comments

@chriseth
Copy link
Contributor

chriseth commented Mar 25, 2020 •
edited by Marenz

  • Any operation that causes a delete on a mapping in storage should be disallowed.
  • Any assignment to something in storage that contains a mapping is disallowed.
    • assignment to struct that contains mapping is disallowed
  • Array pop and (non-empty) push on an array that (recursively) contains a mapping is disallowed.
    • push
    • pop
  • Delete on anything that (recursively) contains a mapping is disallowed.
    Empty push on such arrays is fine.
@chriseth chriseth mentioned this issue Mar 25, 2020
Closed
@chriseth chriseth added breaking change ⚠️ language design :rage4: Any changes to the language, e.g. new features labels Mar 25, 2020
@elenadimitrova elenadimitrova added this to New issues in Solidity via automation May 14, 2020
@elenadimitrova elenadimitrova moved this from New issues to Design Backlog in Solidity May 14, 2020
@hrkrshnn hrkrshnn self-assigned this May 19, 2020
@hrkrshnn hrkrshnn removed their assignment Jul 9, 2020
This was referenced Sep 2, 2020
Merged
Closed
@chriseth chriseth moved this from Design Backlog to Implementation Backlog in Solidity Sep 2, 2020
@Marenz Marenz self-assigned this Aug 24, 2021
@Marenz Marenz mentioned this issue Aug 25, 2021
Merged
@Marenz Marenz moved this from Implementation Backlog to Implementation Backlog Important in Solidity Aug 26, 2021
@Marenz Marenz moved this from Implementation Backlog Important to Review in progress in Solidity Aug 26, 2021
@Marenz Marenz closed this as completed Sep 22, 2021
Solidity automation moved this from Review in progress to Done Sep 22, 2021
@cameel cameel mentioned this issue Jan 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Marenz Marenz

Labels
breaking change ⚠️ language design :rage4: Any changes to the language, e.g. new features
Projects
No open projects
Solidity
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Marenz @chriseth @hrkrshnn