Fix ICE caused by an array of mappings #9702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we should disallow them - sorry :) |
Should we move #7410 back from the implementation backlog then? Or is there a consensus how to proceed? |
|
One way to proceed is to disallow |
a3d4
force-pushed
the
fix-7410-arrays-of-mappings
branch
from
cb49b91
to
d575941
Compare
a3d4
commented
Sep 27, 2020
libsolidity/analysis/TypeChecker.cpp
Outdated
Comment on lines
2685
to
2691
| if ( | ||
| ((funType->kind() == FunctionType::Kind::ArrayPush && arguments.value().numArguments() != 0) || funType->kind() == FunctionType::Kind::ArrayPop) && | ||
| exprType->containsNestedMapping() | ||
| ) |
There was a problem hiding this comment.
if (
auto arrayType = dynamic_cast<ArrayType const*>(exprType);
arrayType &&
arrayType->location() == DataLocation::Storage &&
arrayType->containsNestedMapping() &&
((memberName == "push" && arguments.value().numArguments() != 0) || memberName == "pop")
)
Would this be better?
|
Several tests fail because of |
|
Disallowing Just out of curiosity: |
a3d4
force-pushed
the
fix-7410-arrays-of-mappings
branch
from
d575941
to
e18652f
Compare
a3d4
force-pushed
the
fix-7410-arrays-of-mappings
branch
from
e18652f
to
3c876fc
Compare
In the sense that it does not crash the compiler, yes. |
chriseth
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7410 by disallowing
.push(<arg>)for storage arrays with mappings.@chriseth @leonardoalt @hrkrshnn
From the #7410 discussion, I somewhat concluded that the idea is to forbid arrays with (nested) mappings.I added a simple check and updated several test cases (more needs to be updated). Is it the intended direction? The impact (in terms of the number of failing tests) is rather big.Disallows
.push(<arg>)andfor storage arrays with nested mappings..pop()