Remove install_deps script. #12237
Merged
Remove install_deps script. #12237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An option would be to add subsections with the concrete commands to install the dependencies for a selected set of distributions (e.g. debian, ubuntu, redhat, archlinux, osx) to subsections in the docs - that's still better than asking users to run an opaque and unmaintained script... |
axic
approved these changes
Nov 4, 2021
There was a problem hiding this comment.
Checked that the documentation mentions cmake/boost, and it does. The install script only added cmake, boost, and z3/cvc4 in some cases.
I think we wanted to get rid of this for a while, because we can't reasonably maintain it, but I'm fine either way.
Please wait for other reviews.
chriseth
approved these changes
Nov 4, 2021
|
This fixes #12237. I wonder if github will close it if I add it to the description now? |
|
Apparently it won't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12237.
Just throwing this out there, s.t. we hopefully finally get rid of this script eventually.
We may want to extend the documentation a bit - however, actually all required information is in there already, so maybe it's just fine and we can revisit, if we notice people complaining about not being able to setup a build?