[.clang-format ] Update prohibited property 'AlignEscapedNewlinesLeft'. #14115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 'AlignEscapedNewlines' set to 'Left' is now the correct property.
r0qs
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
I just saw that
AlignEscapedNewlinesLeftis an prohibited property nowadays.
I'm fine with the change, but the option seems to still available: https://github.com/llvm/llvm-project/blob/main/clang/lib/Format/Format.cpp#L820
However, I'm not able to find now the correct commit
Here is the commit that changed it: llvm/llvm-project@7fdbb3f
Yep, it is still there for backward compatibility. But I think it's better to update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just saw that
AlignEscapedNewlinesLeftis an prohibited property nowadays. It seem to got implemented before LLVM 5.0. However, I'm not able to find now the correct commit. See llvm/llvm-project#31808 (comment). I was not able to find the related revisionr302428in the current GitHub repository. It seem to have got merged after LLVM 4.0.1-rc1 and before LLVM 4.0.1-rc2 not sure what happened there.