Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds NatSpec to AST for struct definitions. #14119

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

veniger
Copy link
Contributor

@veniger veniger commented Apr 13, 2023

Added NatSpec to AST for struct definitions
Fixes #12295

@github-actions
Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

Changelog.md Outdated
@@ -29,6 +29,7 @@ Language Features:


Compiler Features:
* NatSpec: Add support for NatSpec documentation in ``struct`` definition.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the changelog for the already released 0.8.19 version; you're gonna have to move this up to line 10 (after the enum entry).

Changelog.md Outdated Show resolved Hide resolved
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than some minor indent/changelog issues.

BTW, please remember to switch draft PRs to reviewable when they're ready for review.

test/libsolidity/SolidityNatspecJSON.cpp Outdated Show resolved Hide resolved
@veniger veniger marked this pull request as ready for review April 18, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AST] Consider expanding the use of NatSpec documentation to all declarations.
3 participants