Fix undefined order of functions when generating code for index expressions #14374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekpyron
previously approved these changes
Jul 10, 2023
cameel
force-pushed
the
fix-non-deterministic-ir-function-generation-order
branch
from
7b9303c
to
8e426c7
Compare
ekpyron
previously approved these changes
Jul 11, 2023
cameel
force-pushed
the
fix-non-deterministic-ir-function-generation-order
branch
from
8e426c7
to
bda76a1
Compare
cameel
force-pushed
the
fix-non-deterministic-ir-function-generation-order
branch
from
bda76a1
to
a57a7c2
Compare
…ating code for index expressions
cameel
force-pushed
the
fix-non-deterministic-ir-function-generation-order
branch
from
a57a7c2
to
5b70830
Compare
matheusaaguiar
approved these changes
Jul 13, 2023
| @@ -17,6 +17,7 @@ Compiler Features: | |||
|
|
|||
|
|
|||
| Bugfixes: | |||
| * Code Generator: Fix not entirely deterministic order of functions in unoptimized Yul output. The choice of C++ compiler in some cases would result in different (but equivalent) bytecode (especially from native binaries vs emscripten binaries) | |||
There was a problem hiding this comment.
Suggested change
| * Code Generator: Fix not entirely deterministic order of functions in unoptimized Yul output. The choice of C++ compiler in some cases would result in different (but equivalent) bytecode (especially from native binaries vs emscripten binaries) | |
| * Code Generator: Fix not entirely deterministic order of functions in unoptimized Yul output. The choice of C++ compiler in some cases would result in different (but equivalent) bytecode (especially from native binaries vs emscripten binaries). |
There was a problem hiding this comment.
Well, we can still fix this when we sort the changelog before release. If this was a bigger mistake I'd push a new PR, but for a dot it's not worth it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14361.