Support --allow-path in the CLI #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
requested changes
Apr 19, 2017
solc/CommandLineInterface.cpp
Outdated
| (g_argMetadataLiteral.c_str(), "Store referenced sources are literal data in the metadata output.") | ||
| ( | ||
| g_argAllowPath.c_str(), | ||
| po::value<string>()->value_name("path"), |
axic
force-pushed
the
allow-path
branch
2 times, most recently
from
226aadd
to
ef9e809
Compare
|
Changed. Please review the docs, don't know if the sentence is true there :) |
chriseth
reviewed
Apr 20, 2017
Changelog.md
Outdated
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| Features: | |||
| * Support ``interface`` contracts. | |||
| * Commandline interface: Support ``--allow-paths`` to define trusted import paths. Note: the | |||
| path(s) of the supplied contract(s) is always trusted. | |||
There was a problem hiding this comment.
Should be supplied source file(s).
chriseth
reviewed
Apr 20, 2017
docs/using-the-compiler.rst
Outdated
| @@ -29,6 +29,8 @@ files reside, so things like ``import "/etc/passwd";`` only work if you add ``=/ | |||
|
|
|||
| If there are multiple matches due to remappings, the one with the longest common prefix is selected. | |||
|
|
|||
| Important to note is that paths of included sources files and paths defined by remappings are allowed to include, but everything else is rejected. Additional paths can be added via the ``--allow-paths /sample/path,/another/sample/path`` switch. | |||
There was a problem hiding this comment.
paths of source files specified on the commandline and paths defined by remappings...
It is probably better to put that in line 16.
There was a problem hiding this comment.
Reworded, still not sure. Where exactly at line 16 should it go?
axic
force-pushed
the
allow-path
branch
2 times, most recently
from
09899ca
to
8bf8420
Compare
chriseth
approved these changes
Apr 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.