Include license and warranty statement with solc. #2353
Conversation
solc/license_escaped.h
Outdated
| might be different; for a GUI interface, you would use an "about box". | ||
|
|
||
| You should also get your employer (if you work as a programmer) or school, | ||
| if any, to sign a "copyright disclaimer" for the program, if necessary. |
There was a problem hiding this comment.
This is not escaped here (well there are a couple of other instances).
There was a problem hiding this comment.
It is correctly escaped, this juts seems to be an error in github's syntax hilighting.
|
Wouldn't it be better to have a script during the build process which creates the file out of Escaping with |
chriseth
force-pushed
the
license_output
branch
2 times, most recently
from
16860a2
to
c890f74
Compare
|
Sorry, took a while but this should now be the working version. |
solc/CommandLineInterface.cpp
Outdated
| R"(solc, the Solidity commandline compiler. | ||
| po::options_description desc(R"(solc, the Solidity commandline compiler. | ||
|
|
||
| Solidity Copyright (C) 2014-2017 Solidity contributors. |
There was a problem hiding this comment.
Do we need the copyright statement here? It is not even in the headers yet.
There was a problem hiding this comment.
Perhaps we can do without, but the GPL "how to apply the license" suggests this. The thing is that the copyright is just shared by the authors which I think is the default, so perhaps we can just remove it.
There was a problem hiding this comment.
I think we should sort this in a separate PR which also adds it to the files. Gives us more time to find the proper wording :)
There was a problem hiding this comment.
I guess "Copyright (C) 2014-2017 the Solidity authors and contributors." should be more clear. There seem to be a distinction between the two words, whereas author means the "initial creator", while contributor is anyone else.
|
Perhaps it is better to just drop the statement. I'm not sure if contributors actually would get the copyright by default (as opposed to just the authors). |
We should probably also clean some headers with this pull request.