Use npm instructions FIRST, fixes #3376 #3378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Jan 5, 2018
| @@ -9,6 +9,8 @@ Using the compiler | |||
| Using the Commandline Compiler | |||
| ****************************** | |||
|
|
|||
| If you installed Solidity using npm then run the compiler with ``solcjs``. | |||
There was a problem hiding this comment.
Actually most of the features described here are not supported by solcjs. I'd rather just include a .. note :: mentioning that.
There was a problem hiding this comment.
The inconsistency is painful. If npm is the recommended install method then the main usage instructions should target an npm install. The additional instructions should be a separate section, because the reader will need to stop what they're doing, go back and then reinstall everything from the not default install instructions.
14 tasks
|
Closing this in favour of #3603. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.