-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect Fedora properly in install_deps.sh #5513
Conversation
It seems the Travis test is failing because it's trying to run the script in a docker image, would it be possible to know which docker image it's pulling? I've looked at the test directory and can't find it there. |
The docker image is |
Given that the Travis CI is not a required test maybe it's not needed but I thought I'd have to fix the issues that made the travis test fail before merging |
Codecov Report
@@ Coverage Diff @@
## develop #5513 +/- ##
===========================================
+ Coverage 88.14% 88.19% +0.05%
===========================================
Files 319 319
Lines 31672 31649 -23
Branches 3802 3791 -11
===========================================
- Hits 27917 27914 -3
+ Misses 2468 2459 -9
+ Partials 1287 1276 -11
|
Thanks! |
Make the double quotes around the distro name optional so it matches properly in Fedora (`NAME=Fedora`)
Sorry, it was still not working, had to change it again. Fingers crossed! |
Description
Make the double quotes around the distro name optional so it matches properly in Fedora (
NAME=Fedora
)Fixes #5512
Checklist