-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unary + from the type system #5514
Conversation
There was an error when running
Please check that your changes are working as intended. |
The unary operator tests now return:
If the type system disallows it, can we remove it from the syntax checker? |
@leonardoalt I would first like to see the full test updates without removal from the syntax checker. |
979a47a
to
f6767a6
Compare
Please also update unary_operators in SolidityExpressionCompiler.cpp |
Working on it |
Codecov Report
@@ Coverage Diff @@
## develop #5514 +/- ##
===========================================
- Coverage 88.12% 88.12% -0.01%
===========================================
Files 324 324
Lines 31955 31954 -1
Branches 3828 3828
===========================================
- Hits 28161 28160 -1
Misses 2498 2498
Partials 1296 1296
|
Remove unary + from the type system
Done |
Thanks a lot! |
Description
Remove unary + from the type system, as requested in #5470
Fixes #5470
Checklist
Not sure if any new test is needed, feedback would be appreciated.