Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ecrecover tests #1039

Closed
axic opened this issue Jun 8, 2022 · 3 comments
Closed

Improve ecrecover tests #1039

axic opened this issue Jun 8, 2022 · 3 comments
Assignees

Comments

@axic
Copy link
Member

axic commented Jun 8, 2022

The negative tests seem to be mostly concerned by checking dirty bits for the v value, but there aren't many trying out various 1-byte values. On example was discussed under #941.

The goal would be to include cases with v values 0, 1, 2, 3, 29, 30 and a bunch of other random values, plus potentially those used with chainid based signing.

stPreCompiledContracts2/CALLCODEEcrecoverV_prefixedf0Filler could be used to easily extend this test suite.

(See also ethereum/yellowpaper#860)

@winsvega
Copy link
Collaborator

we have more transaction signature tests here
https://github.com/ethereum/tests/tree/develop/src/TransactionTestsFiller

have you run it?

@axic
Copy link
Member Author

axic commented Dec 12, 2022

I see these tests were added in #1080, but they seem to be enabled on >=London only. Any reason for that? They should be enabled since Frontier, because the ecrecover precompile never changed.

@axic
Copy link
Member Author

axic commented Dec 12, 2022

we have more transaction signature tests here
https://github.com/ethereum/tests/tree/develop/src/TransactionTestsFiller

@winsvega Sorry for the late response, the tests cases I was missing are not transaction encoding, but ecrecover precompile. @qbzzt did those tests however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants