Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retesteth alethIPCDebug: don't hardcode absolute path to the socket #653

Closed
gumb0 opened this issue Nov 7, 2019 · 10 comments
Closed

retesteth alethIPCDebug: don't hardcode absolute path to the socket #653

gumb0 opened this issue Nov 7, 2019 · 10 comments

Comments

@gumb0
Copy link
Member

gumb0 commented Nov 7, 2019

"socketAddress" : "/home/wins/.ethereum/geth.ipc",

This works only for wins.

@winsvega
Copy link
Collaborator

winsvega commented Nov 8, 2019

You supposed to change it to your local path.

@gumb0
Copy link
Member Author

gumb0 commented Nov 11, 2019

Perhaps this should be a command line argument to retesteth instead of config file. With a default being ~/.ethereum/geth.ipc

@gumb0
Copy link
Member Author

gumb0 commented Nov 11, 2019

On the other hand, if user is supposed to edit these files locally often, I think it shouldn't happen inside the git repo. retesteth should copy them on the first run into some dir like maybe ~/.retesteth and then read them from there always.

@gumb0
Copy link
Member Author

gumb0 commented Nov 11, 2019

I don't really understand why these configs live here in tests repo, either. They're very retesteth-specific, it seems they should be there.

@gumb0
Copy link
Member Author

gumb0 commented Nov 12, 2019

It's very annoying to deal with local changes in git repo, when you want to update tests / change tests branch etc.

Also there's no reason to tie changes in config formats to the changes in tests - say I want to try various versions of tests, switching between the branches. But if you also make changes to what is the correct format of configs, only some branches will work, only those where configs have the format corresponding to my retesteth version.

In other words, it would be better if the code parsing the configs is changed in sync with changes in configs themselves, would be simpler if this happens in a single repo (retesteth)

@winsvega
Copy link
Collaborator

winsvega commented Nov 13, 2019

perhaps move it to the retesteth repo?

you are not supposed to change this configs often actually.

@gumb0
Copy link
Member Author

gumb0 commented Nov 13, 2019

retesteth repo would be a better place, I think

@winsvega
Copy link
Collaborator

Then it looks like if to move this configs to retesteth repo it will integrate it on compilation time and then a binary deploy to . retesteth config folder

@gumb0
Copy link
Member Author

gumb0 commented Nov 14, 2019

Sounds good to me.

@winsvega
Copy link
Collaborator

now retesteth issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants