-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retesteth alethIPCDebug: don't hardcode absolute path to the socket #653
Comments
You supposed to change it to your local path. |
Perhaps this should be a command line argument to retesteth instead of config file. With a default being |
On the other hand, if user is supposed to edit these files locally often, I think it shouldn't happen inside the git repo. retesteth should copy them on the first run into some dir like maybe |
I don't really understand why these configs live here in tests repo, either. They're very retesteth-specific, it seems they should be there. |
It's very annoying to deal with local changes in git repo, when you want to update tests / change tests branch etc. Also there's no reason to tie changes in config formats to the changes in tests - say I want to try various versions of tests, switching between the branches. But if you also make changes to what is the correct format of configs, only some branches will work, only those where configs have the format corresponding to my retesteth version. In other words, it would be better if the code parsing the configs is changed in sync with changes in configs themselves, would be simpler if this happens in a single repo (retesteth) |
perhaps move it to the retesteth repo? you are not supposed to change this configs often actually. |
retesteth repo would be a better place, I think |
Then it looks like if to move this configs to retesteth repo it will integrate it on compilation time and then a binary deploy to . retesteth config folder |
Sounds good to me. |
now retesteth issue |
tests/Retesteth/alethIPCDebug/config
Line 4 in 59490b4
This works only for wins.
The text was updated successfully, but these errors were encountered: