Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The recent tests changes #763

Closed
winsvega opened this issue Nov 27, 2020 · 5 comments
Closed

The recent tests changes #763

winsvega opened this issue Nov 27, 2020 · 5 comments
Labels

Comments

@winsvega
Copy link
Collaborator

winsvega commented Nov 27, 2020

The recent tests changes:
EIPS covered with Berlin test configuration (geth YOLOv2, YOLOv3)

Update all:
PR #723
PR #775

EIP2929 (https://eips.ethereum.org/EIPS/eip-2929)
Gas cost increases for state access opcodes
PR #760
PR #756
PR #745

EIP2537 (https://eips.ethereum.org/EIPS/eip-2537)
Precompile for BLS12-381 curve operations
PR #713

REMOVED: #776

EIP2315 (https://eips.ethereum.org/EIPS/eip-2315)
Simple Subroutines for the EVM
PR #693
PR #685

EIP2565 (https://eips.ethereum.org/EIPS/eip-2565)
ModExp Gas Cost
existing test regeneration will test out the changes
PR: #775
PR: #779
PR: #777

EIP2718 - EIP2930 (https://eips.ethereum.org/EIPS/eip-2718, https://eips.ethereum.org/EIPS/eip-2930)
(Typed Transaction Envelope, Optional access lists)
New test format (access list test example): PR: https://github.com/ethereum/tests/pull/772/files
Access list tests PR: #774

VMTests rework under GeneralStateTests
PR: #771

@holiman
Copy link
Contributor

holiman commented Dec 1, 2020

EIP 2565 (modexp repricing)
Looks like 2537 is not going to be included
EIP 2930 + 2817 (still being finalized)

@holiman
Copy link
Contributor

holiman commented Dec 1, 2020

Sorry, GH didn't update the page, so I didn't see your edits until after I posted

@winsvega
Copy link
Collaborator Author

moved to pre releases

@holgerd77
Copy link
Contributor

Hi,
thanks so much for this, these new releases are really great! 😄

One small suggestion: I think it would be better to not do pre-releases at all but just do everything as a normal release. I realized lately that for us as a user a "final" release has very much low relevance since we just update from release to release and at the same time it is unfortunate with the pre-releases that this leads to having this super-old v7.0.0 release displayed on the main GitHub page as the latest release. This will likely confuse people.

image

@holgerd77
Copy link
Contributor

Ah, and as a side note: this suggestion is also influenced by the experiences from #692 where we (so you guys and me)were waiting for a final release for months, which made not so much sense since the clients needed to update the tests anyhow, being towards a "final" release or not.

So I guess it's not really worth to focus so much on final releases as I initially did, hardfork planning is often somewhat unpredictable and from my observation of the work here on the repo it is often hard or just not really possible to find a good "sweet spot" for a final release.

This will likely be directly again the case with this planning for Berlin and London happening somewhat in parallel, so it might very well be the case here that we get into some repo state here where Berlin tests are not yet "finalized" but the first London tests need already to be merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants