Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some client other then geth support t8ntool protocol for test generation / vmtracing #816

Closed
winsvega opened this issue Mar 29, 2021 · 8 comments

Comments

@winsvega
Copy link
Collaborator

winsvega commented Mar 29, 2021

Total 4208 (100%)

geth 3432 (81.56%)
openethereum 478 (11.36%)
parity-ethereum 156 (3.71%)
nethermind 61 (1.45%)
turbo-geth 39 (0.93%)
besu 22 (0.52%)
coregeth 13 (0.31%)

https://www.ethernodes.org/

@qbzzt
Copy link
Collaborator

qbzzt commented Mar 30, 2021

Asked openethereum at openethereum/openethereum#340

@qbzzt
Copy link
Collaborator

qbzzt commented Apr 2, 2021

We decided to do the emulation at the t8ntool layer so we'll be able to use the openethereum also to generate tests and do whatever features we add in the future.

@qbzzt
Copy link
Collaborator

qbzzt commented Apr 7, 2021

Just a note to myself, to create a Docker with openethereum, use:

FROM ubuntu:18.04 as retesteth

# Configure the OS
ENV TZ=Etc/UTC
RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone  \
    && apt-get update
RUN apt-get install --yes git curl apt-utils cmake make perl psmisc clang pkg-config yasm \
     && rm -rf /var/lib/apt/lists/*

# Install Rust
RUN curl https://sh.rustup.rs -sSf > /rustup.sh \
    && chmod +x /rustup.sh \
    && /rustup.sh -y

# Install OpenEthereum
RUN cd /     \
    && git clone https://github.com/openethereum/openethereum
    
RUN cd /openethereum \
    && ~/.cargo/bin/cargo build --release -p evmbin

RUN ls -l /openethereum/target/release

ENTRYPOINT ["/bin/sh"]

@qbzzt
Copy link
Collaborator

qbzzt commented Apr 10, 2021

Another note to self.

Naturally, t8ntool doesn't get the expected output. A json state test, OTOH, must have that output.

The solution is to have synthetic output:

        "post" : {
            "Berlin" : [ {
                  "indexes": { "data":0, "gas":0, "value":0},
                  "hash": "0x0000000000000000000000000000000000000000000000000000000000000000"
            } ]
        },

However, the transaction is supposed to have the private key, and that isn't in txs.json.

@qbzzt
Copy link
Collaborator

qbzzt commented Apr 13, 2021

Almost working

package.json.txt
t8n_oe.js.txt

@winsvega
Copy link
Collaborator Author

winsvega commented May 7, 2021

hm. not really http://retesteth.ethdevops.io/results/log//2021-05-03-1620016370-oewrap.txt
well we gave it a try. Lets focus on tests and besu client support. as its essential for proper eip1559 testing.
besu has implemented rpc so we can test blockchain rules directly on the client

@qbzzt
Copy link
Collaborator

qbzzt commented Jun 29, 2021

OE is deprecated, so that work is no longer relevant, but besu works great with retesteth these days. So I don't think we need this issue anymore.

@winsvega
Copy link
Collaborator Author

winsvega commented Feb 1, 2022

Yes. Just that they wont fix the errors in test execution I report

@winsvega winsvega closed this as completed Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants