Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay protocol routing table management #109

Closed
Tracked by #118
njgheorghita opened this issue Sep 17, 2021 · 2 comments
Closed
Tracked by #118

Overlay protocol routing table management #109

njgheorghita opened this issue Sep 17, 2021 · 2 comments

Comments

@njgheorghita
Copy link
Collaborator

Logic for handling population and liveness routing table responsibilities needs implementation in OverlayProtocol.

re: https://github.com/ethereum/trin/pull/103/files#r709322642
@jacobkaufmann
Copy link
Collaborator

Happy to take this up. May end up splitting this into separate issues for population (adding new peers via nodes) and liveness (maintenance of existing peers via ping/pong).

@ogenev
Copy link
Member

ogenev commented Sep 21, 2021

Happy to take this up. May end up splitting this into separate issues for population (adding new peers via nodes) and liveness (maintenance of existing peers via ping/pong).

Cool, overlay events are handled now in trin-core/src/portalnet/overlay.rs. I feel we have to put the logic for the routing table management in the same file, or probably event better, create new overlay folder and split overlay functionality in separate files...

@njgheorghita njgheorghita mentioned this issue Sep 27, 2021
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jacobkaufmann @njgheorghita @ogenev