Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Structure #185

Closed
1 of 6 tasks
njgheorghita opened this issue Nov 16, 2021 · 1 comment
Closed
1 of 6 tasks

Testing Structure #185

njgheorghita opened this issue Nov 16, 2021 · 1 comment

Comments

@njgheorghita
Copy link
Collaborator

njgheorghita commented Nov 16, 2021

Proposed direction of trin's testing structure

Unit tests

  • If it can be written as a unit test, it should be.

tests module

  • Integration tests for trin-specific functionality
    • Runs ethportal-peertest against trin (or a group of trin nodes)
    • Contains additional integration tests that don't fit nicely into ethportal-peertest (routing table management, etc.)

ethportal-peertest

  • A tool to test any client in a cross-client compatible manner
  • Contains a set of json fixtures that other clients can pull in to test against

Todos

  • Common test library to share logic for trin-specific and client-agnostic integration tests
  • Tests directory to hold integration tests
  • Use match / something else to validate that every desired endpoint is consistently tested re: https://github.com/ethereum/trin/pull/188/files#r751917711
  • Use ethportal-peertest as a library in tests directory
  • Invoke tests directory tests in Circle CI
  • Cross-Client utp tests
@njgheorghita
Copy link
Collaborator Author

Closing since test structure is already implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant