Get CircleCI lint check check working, then pass tests #11
Conversation
carver
force-pushed
the
circle-ci-test-branch
branch
from
168cdb3
to
142129d
Compare
|
There weren't any formatting errors to test against, but I temporarily pushed a commit with one to confirm that CI fails. |
|
After this, I'll actually start running the project tests |
Only libraries should ignore Cargo.lock according to: https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries
- Fix the circle CI image version: they wanted the config version number, not the rust version. - Install libssl-dev in OS to support openssl-sys cargo package install - When referencing targets in the rust orb, must prefix with rust/ - Speed up CI by building debug instead of release (saves about 50s) - Save target/ in cache to speed up build time - Run rustfmt in CircleCI* * The rust/format job runs `cargo fmt` which only modifies the files in place, it doesn't actually fail or display the needed changes. So switch it to `cargo fmt -- --check` which passes --check into rustfmt, and causes CI to fail when formatting is broken (as desired).
carver
force-pushed
the
circle-ci-test-branch
branch
from
142129d
to
c439f99
Compare
|
I didn't do anything manual with "Cargo.lock", just ran a |
There was a problem hiding this comment.
Looks good! Are there clippy settings somewhere that I'm missing? I've run clippy locally and not able to reproduce the linting warnings. Not sure why, but as long as it's being caught in ci then it's probably something wrong with my local setup that I'll sus out eventually
.circleci/config.yml
Outdated
| jobs: | ||
| lint-build-test: | ||
| description: | | ||
| Check linting with Clippy, then build the crate. |
There was a problem hiding this comment.
nitpick ... then build the crate and run tests.
Maybe the version of rust (v1.51.0)? The VM seems to install clippy normally: |
carver
force-pushed
the
circle-ci-test-branch
branch
from
c978429
to
ced0b54
Compare
Fixes #3
Todo:
rustfmt