Add HashDelayQueue utility #139
Conversation
jacobkaufmann
force-pushed
the
hash-delay-queue
branch
3 times, most recently
from
301651a
to
d22eca6
Compare
|
|
||
| sleep(Duration::from_millis(1)).await; | ||
|
|
||
| let entry = assert_ready_ok_some!(poll!(queue)); |
There was a problem hiding this comment.
It feels a little strange to me that an assert_* statement returns some kind of value... but I see that's also the behavior of some of these tokio assert_*s so it's consistent
| K: std::cmp::Eq + std::hash::Hash + std::clone::Clone + Unpin, | ||
| { | ||
| /// The given entries. | ||
| entries: HashMap<K, delay_queue::Key>, |
There was a problem hiding this comment.
Maybe expand the comment just a bit here to explain the value
| /// Resets the expiration timeout of an entry for `key`. Returns `true` if the key existed, | ||
| /// `false` otherwise. | ||
| /// | ||
| /// # Panics |
There was a problem hiding this comment.
Why panic (here and insert_with_timeout() instead of returning a Result of some kind?
There was a problem hiding this comment.
The panic here is because that is how the tokio-util library is handling the exception. It looks like the maximum duration is ~2 years, so I think a panic is acceptable here. We should never insert anything with such a long delay.
| #[tokio::test] | ||
| async fn clear() { | ||
| time::pause(); | ||
|
|
There was a problem hiding this comment.
nitpick - but it seems trivial to go ahead and bump up the # of entries here and in len() to something like 3. I wouldn't call it necessary, you just never know what bugs are hiding above the 0-1 range
There was a problem hiding this comment.
That's a good callout! I'll update the tests.
jacobkaufmann
force-pushed
the
hash-delay-queue
branch
from
d22eca6
to
bc99404
Compare
Add a
HashDelayQueuestruct that can act as a generator that yields "expired" items. This struct is intended for the implementation of routing table management. With aHashDelayQueue, we can insert keys with a given timeout or delay, and when polled, the delay queue will yield an expired item (if one exists).trin_core::utilsmodule.HashDelayQueueutility in thetrin_core::utilsmodule.