Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Some improvements to the DappNode package #2009

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

cburgdorf
Copy link
Contributor

@cburgdorf cburgdorf commented Sep 2, 2020

What was wrong?

  1. It's hard to guess the endpoint for the JSON-RPC requests

  2. The --enable-http flag is gone and --enable-http-apis need to be used.

How was it fixed?

  1. Display the JSON-RPC API URL on the package view
  2. Enable eth and net JSON-RPC APIs by default (needed to visualize syncing progress on the dashboard)

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

Copy link
Contributor

@njgheorghita njgheorghita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@cburgdorf cburgdorf merged commit 85d8e7a into ethereum:master Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants