This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Update eip1085 schema to enforce account formatting #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
bugfix-incomplete-schema
branch
5 times, most recently
from
1e6978e
to
d02cadf
Compare
njgheorghita
changed the title
pipermerriam
approved these changes
Oct 23, 2020
njgheorghita
force-pushed
the
bugfix-incomplete-schema
branch
from
d02cadf
to
fdc687c
Compare
|
Nice tests 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
In jsonschema a
"propertyNames"field is required to enforce that all of an object's keys conform to a pattern. Without this addition to the jsonschema - it wasn't properly enforcing that all keys inAccountswere0x-prefixed addresses.How was it fixed?
Added the necessary field.
To-Do
Cute Animal Picture