Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Make epochs first class citizens and epoch trans at end of epoch #235

Closed
hwwhww opened this issue Jan 28, 2019 · 1 comment · Fixed by #256
Closed

Make epochs first class citizens and epoch trans at end of epoch #235

hwwhww opened this issue Jan 28, 2019 · 1 comment · Fixed by #256
Assignees
@NIC619
Labels
eth2.0

Comments

@hwwhww
Copy link
Contributor

hwwhww commented Jan 28, 2019 •
edited
Loading

What is wrong?

Spec-PRs:

How can it be fixed

These two goals are twisted together. Ideally, we can start at ethereum/consensus-specs#499 and then do ethereum/consensus-specs#492 separately, but I suspect it will be harder to review...
@hwwhww hwwhww added the eth2.0 label Jan 28, 2019
This was referenced Jan 28, 2019
Merged
Merged
@NIC619 NIC619 self-assigned this Jan 30, 2019
@NIC619
Copy link
Contributor

NIC619 commented Jan 30, 2019

What's left from #228 :

  • slot_to_epoch
  • move get_current_epoch_attestations/get_previous_epoch_attestations to state

@jannikluhn jannikluhn mentioned this issue Feb 1, 2019
Merged
@NIC619 NIC619 mentioned this issue Feb 4, 2019
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NIC619 NIC619

Labels
eth2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make epoch first class and update epoch transition rule NIC619/trinity
2 participants
@hwwhww @NIC619