This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Make epoch first class and update epoch transition rule #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_committee_count_per_slot, get_previous_epoch_committee_count_per_slot, get_current_epoch_committee_count_per_slot, entry_exit_effect_slot
GENESIS_EPOCH, FAR_FUTURE_SLOT, SEED_LOOKAHEAD, ENTRY_EXIT_DELAY, ETH1_DATA_VOTING_PERIOD, MIN_VALI DATOR_WITHDRAWAL_EPOCHS
AttestationData.justified_slot, Exit. slot, State(validator_registry_update_slot/previous_epoch_calculation_slot/current_epoch_calculation_slot/previous_justified_slot/justified_slot/finalized_slot), Validator.(activation_slot/exit_slot/withdrawal_slot/penalized_slot), Crosslink.slot, Fork.slot
is_active_validator, get_active_validator_indices, get_shuffling, get_crosslink_committees_at_slot
get_randao_mix, get_active_index_root, generate_seed, get_fork_version, get_domain, verify_slashable_vote_data, is_double_vote, is_surround_vote
get_initial_beacon_state, validate_proof_of_possession, activate_validator, exit_validator, penalize_validator
fix get_previous_epoch_attestations/get_current_epoch_attestations
fix process_crosslinks
This was referenced Feb 4, 2019
process_validator_registry, process_final_updates
NIC619
changed the title
NIC619
force-pushed
the
first_class_epoch_and_epoch_transition
branch
from
05675c6
to
98c55f8
Compare
hwwhww
reviewed
Feb 4, 2019
| current_epoch = state.current_epoch(config.EPOCH_LENGTH) | ||
| next_epoch = state.next_epoch(config.EPOCH_LENGTH) | ||
| previous_index = current_epoch % config.LATEST_PENALIZED_EXIT_LENGTH | ||
| current_index = next_epoch % config.LATEST_PENALIZED_EXIT_LENGTH | ||
|
|
||
| state = state.copy( |
There was a problem hiding this comment.
Should we update latest_index_roots in this PR?
There was a problem hiding this comment.
I think it's handled in process_validator_registry?
https://github.com/ethereum/trinity/blob/master/eth2/beacon/state_machines/forks/serenity/epoch_processing.py#L142-L172
There was a problem hiding this comment.
Ahhh you're right!!!
I was looking for these changes needed to be updated:
index_root = hash_eth2(
b''.join(
[
index.to_bytes(32, 'big')
for index in active_validator_indices
]
)
)
latest_index_roots = update_tuple_item(
state.latest_index_roots,
next_epoch % config.LATEST_INDEX_ROOTS_LENGTH,
index_root,
)to
In spec: Set state.latest_index_roots[(next_epoch + ENTRY_EXIT_DELAY) % LATEST_INDEX_ROOTS_LENGTH] = hash_tree_root(get_active_validator_indices(state, next_epoch + ENTRY_EXIT_DELAY)).
But now I found these changes belong to #258. 😢
docstring, TODO, naming
hwwhww
approved these changes
Feb 4, 2019
pipermerriam
reviewed
Feb 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fix #235
How was it fixed?
*_slotto*_epochGENESIS_EPOCHFAR_FUTURE_SLOT->FAR_FUTURE_EPOCHSEED_LOOKAHEADENTRY_EXIT_DELAYETH1_DATA_VOTING_PERIODMIN_VALIDATOR_WITHDRAWAL_EPOCHSget_epoch_start_slotslot_to_epochget_committee_count_per_slot->get_epoch_committee_countget_previous_epoch_committee_count_per_slot->get_previous_epoch_committee_countget_current_epoch_committee_count_per_slot->get_current_epoch_committee_countentry_exit_effect_slot->get_entry_exit_effect_epochis_active_validator(Validator.is_active)get_active_validator_indicesget_shufflingget_crosslink_committees_at_slotget_randao_mixget_active_index_rootgenerate_seedget_fork_versionget_domainverify_slashable_vote_datais_double_voteis_surround_voteget_initial_beacon_statevalidate_proof_of_possessionactivate_validatorexit_validatorpenalize_validatorstate.latest_randao_mixesprocess_randaoor update afterRANDAO processing #252 is merged
process_eth1_dataor update afterImplement per-block processing - eth1 data #253 is merged
process_attester_slashingsprocess_exitsget_current_epoch_attestations/get_previous_epoch_attestationshelper functionsprocess_et1_data_votesprocess_justificationprocess_crosslinksprocess_rewards_and_penaltiesprocess_ejectionsupdate_validator_registryprocess_penalties_and_exits(part of [validator-registry-and-shuffling-seed-dat](https://github.com/ethereum/eth2.0-specs/blob/master/specs/core/0_beacon-chain.md#validator-registry-and-shuffling-seed-data) )
process_validator_registryprocess_final_updatesCute Animal Picture