Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Implement swap-or-not shuffle #272

Closed
hwwhww opened this issue Feb 12, 2019 · 1 comment · Fixed by #363
Closed

Implement swap-or-not shuffle #272

hwwhww opened this issue Feb 12, 2019 · 1 comment · Fixed by #363
Assignees
@hwwhww
Labels
eth2.0 prio: P2 required

Comments

@hwwhww
Copy link
Contributor

hwwhww commented Feb 12, 2019 •
edited
Loading

What is wrong?

Spec issue: ethereum/consensus-specs#563
Spec PRs:

  1. introduce swap-or-not shuffle: Introduce swap-or-not shuffle consensus-specs#576
  2. max list size in `get_permuted_index: Add explicit assert to get_permutated_index consensus-specs#634
  3. fix out-of-bounds in get_shuffling: Fix out-of-bounds in get_shuffling consensus-specs#641

How can it be fixed

  1. Add constants: SHUFFLE_ROUND_COUNT = 90
  2. eth2.beacon._utils.random.py

p.s. the benefit of #271 refactoring will reduce the cost of adding SHUFFLE_ROUND_COUNT to EVERYWHERE.
@hwwhww hwwhww added the eth2.0 label Feb 12, 2019
@djrtwo djrtwo changed the title Implement snap-or-not shuffle Implement swap-or-not shuffle Feb 12, 2019
@ChihChengLiang
Copy link
Contributor

ChihChengLiang commented Feb 19, 2019 •
edited
Loading

Also need to fix get_shuffling together ethereum/consensus-specs#641

@hwwhww hwwhww self-assigned this Mar 4, 2019
This was referenced Mar 4, 2019
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hwwhww hwwhww

Labels
eth2.0 prio: P2 required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add get_permuted_index and new swap-or-not shuffle hwwhww/trinity
2 participants
@ChihChengLiang @hwwhww